Fix unreachable exception handlers by reordering specific exceptions before generic Exception#401
Open
mohityadav8 wants to merge 2 commits intoEAPD-DRB:mainfrom
Open
Fix unreachable exception handlers by reordering specific exceptions before generic Exception#401mohityadav8 wants to merge 2 commits intoEAPD-DRB:mainfrom
mohityadav8 wants to merge 2 commits intoEAPD-DRB:mainfrom
Conversation
…before generic Exception
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…before generic Exception
Linked issue
Existing related work reviewed
Overlap assessment
The current implementation places
except Exceptionbefore more specific exception handlers, making the latter unreachable.Why this PR should proceed
Summary
What changed:
Reordered exception blocks so that specific exceptions (
IOError,IndexError,OSError) appear before the genericExceptionhandler.Why:
In Python, exception handlers are evaluated from top to bottom.
If
Exceptionappears first, it catches all exceptions and prevents later specific handlers from executing.Validation
Validation steps:
except Exceptionappeared before specific exceptions.Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale
N/A