Skip to content

Fix unreachable exception handlers by reordering specific exceptions before generic Exception #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohityadav8 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix unreachable exception handlers by reordering specific exceptions before generic Exception #401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
141ff56
Fix unreachable exception handlers by reordering specific exceptions …
mohityadav8 Apr 1, 2026
b2c19fa
Remove accidental embedded repository
mohityadav8 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions API/Classes/Case/DataFileClass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2262,13 +2262,14 @@ def run( self, solver, caserun, lock=None ):
return response
# urllib.request.urlretrieve(self.dataFile, dataFile)

except Exception as ex:
print(ex) # do whatever you want for debugging.
raise # re-raise exception.
except(IOError, IndexError):
raise IndexError
# Handle specific exceptions first to avoid unreachable handlers
except (IOError, IndexError):
raise
except OSError:
raise OSError
raise
except Exception as ex:
print(ex) # do whatever you want for debugging
raise # re-raise exception

def generateCSVfromCBC(self, data_file, results_file, base_folder=os.getcwd()):
try:
Expand Down Expand Up @@ -2532,13 +2533,15 @@ def generateCSVfromCBC(self, data_file, results_file, base_folder=os.getcwd()):
df_ACI = df_ACI_temp[['r','t','y','AnnualizedInvestmentCost']]
df_ACI = df_ACI[df_ACI['AnnualizedInvestmentCost']!=0]
df_ACI.to_csv(os.path.join(base_folder, 'csv', 'AnnualizedInvestmentCost.csv'), index=None)
except Exception as ex:
print(ex) # do whatever you want for debugging.
raise # re-raise exception.
except(IOError, IndexError):
raise IndexError
# Handle specific exceptions first to avoid unreachable handlers
except (IOError, IndexError):
raise
except OSError:
raise OSError
raise
except Exception as ex:
print(ex) # do whatever you want for debugging
raise # re-raise exception


def generateResultsViewer(self, caserunname):
try:
Expand Down
Loading