Repository navigation
feat(plugins): apply plugin upstream headers to provider calls #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fede-ciliberti
wants to merge
17
commits into
ENTERPILOT:main
Choose a base branch
from
fede-ciliberti:feat/plugin-upstream-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+922
−44
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
99a504a
feat(plugins): apply plugin upstream headers to provider calls
fede-ciliberti 5cbe37f
fix(plugins): canonicalize upstream header names when merging
fede-ciliberti da62937
refactor(plugins): use the shared credential-header list
fede-ciliberti 09c9489
fix(server): apply plugin upstream headers to utility calls
fede-ciliberti f91c75e
docs(plugins): document where upstream headers are forwarded
fede-ciliberti e34f88f
test(llmclient): hand the captured headers over a channel
fede-ciliberti 4021d16
test(llmclient): assert a plugin Host header is denied
fede-ciliberti 5446e62
fix(llmclient): stop applying plugin headers to internal calls
fede-ciliberti 2581095
fix(llmclient): complete the plugin header denial lists
fede-ciliberti 5369d57
docs(plugins): spell out the upstream header contract and its upgrade
fede-ciliberti 4dbe8f0
docs(plugins): spell out the full upstream header deny list
fede-ciliberti 33eee8e
fix(llmclient): deny the remaining hop-by-hop and encoding headers
fede-ciliberti b8a2325
fix(server): carry plugin upstream headers on messages count_tokens
fede-ciliberti 6f43445
docs(plugins): state where upstream headers stop and what is logged
fede-ciliberti 544d180
docs(headeredit): say where upstream_set headers do apply
fede-ciliberti dfd9f3f
docs(plugins): list the connection and encoding names the merge refuses
fede-ciliberti 120f476
docs(plugins): send upstream headers to the attempt's own upstream
fede-ciliberti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: ENTERPILOT/GoModel
Length of output: 27661
Script executed:
Repository: ENTERPILOT/GoModel
Length of output: 8698
Script executed:
Repository: ENTERPILOT/GoModel
Length of output: 6175
Script executed:
Repository: ENTERPILOT/GoModel
Length of output: 3986
Align the Upstream headers introduction with the refusal list.
The introduction says that non-credential values are forwarded. The list below refuses other names, such as
Content-Type,Accept-Encoding, andanthropic-beta. The merge drops these names silently. Update the English, German, Polish, and Chinese introductions to match the list.📝 Suggested fix (English)
Committable suggestion