ci: authenticate the release workflow to GitHub Packages - #2
Merged
Merged
Conversation
release.yml installs dependencies too, and it never got the credential step that ci.yml did — so the first push to main after the modernize merge failed on the same 401 that CI had already been fixed for. CI was green on the PR because the release workflow only runs on push to main. Also backports the empty-token guard to ci.yml so both workflows fail with the command to run rather than a registry error that names neither the secret nor the repo. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adding the empty-token guard to ci.yml replaced the whole step, `env:` block included, so NODE_AUTH_TOKEN was never passed to the shell. The guard then did exactly what it should and reported the secret as empty — the secret is fine; the step could not see it. Both files now have one env binding per authenticate step, checked rather than eyeballed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red. The modernize PR added a GitHub Packages credential step toci.ymlbut not torelease.yml, which installs dependencies too. The first push tomainafter that merge failed on the same 401 CI had already been fixed for.Why the PR was green and
mainwas not:release.ymlruns only onpushtomain, so no pull request can exercise it. The two runs on the merge commit tell the story —CIsucceeded,Releasefailed, same SHA.Worth noting for anything added later: every workflow that runs
pnpm installneeds this step, and only the ones triggered bypull_requestget checked before merge.Also backports the empty-token guard from
next-templateintoci.yml, so both workflows now fail with the command to run rather than a registry error that names neither the secret nor the repository:Length is checked, never the value.
🤖 Generated with Claude Code