Updates small formating/test changes - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes small maintenance and formatting updates across the ROS mule_bridge package tests/build files and a hovermap_api helper script.
Changes:
- Remove
rosunit.unitrun(...)__main__blocks from Python test files and enumerate Python tests explicitly inCMakeLists.txt. - Switch
setup.pyto usesetuptools.setupinstead ofdistutils.core.setup. - Reformat a
rospy.Publisher(...)call for readability.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mule_bridge/mule_bridge/tests/test_protocol.py | Removes __main__ rosunit runner block. |
| src/mule_bridge/mule_bridge/tests/test_history.py | Removes __main__ rosunit runner block; adds (problematic) inline TODO on import. |
| src/mule_bridge/mule_bridge/tests/test_database.py | Removes __main__ rosunit runner block. |
| src/mule_bridge/mule_bridge/setup.py | Uses setuptools for packaging setup. |
| src/mule_bridge/mule_bridge/CMakeLists.txt | Runs nosetests per test file instead of the whole directory. |
| src/hovermap_api/scripts/configure_perception | Formats publisher creation across multiple lines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.