Repository navigation
init: don't inherit a stale recipesRoot on additive setup - #62
Merged
Merged
Conversation
An additive init spread the previous init block and only overwrote recipesRoot/benchmarksRoot/backendCatalogPath when the new run passed them. Installing a packaged recipe (default root) on top of a setup from a custom recipes directory left init.recipeId pointing at a recipe that the stale init.recipesRoot does not contain, so `lloom status` failed with "Unknown recipe lloom-hear" on ennspark03. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Rebased check: no conflicts with current main; still applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An additive `lloom setup` spread the previous `init` block and only overwrote `recipesRoot`, `benchmarksRoot` and `backendCatalogPath` when the new run passed them. Installing a packaged recipe on top of a setup from a custom recipes directory therefore left `init.recipeId` naming a recipe that the stale `init.recipesRoot` doesn't contain. On ennspark03, `lloom status` failed with `Unknown recipe lloom-hear. Known recipes: spark03-cuda-media, spark03-embedding-flux`.
The fix records this run's sources in `init`, since the recipe is only ever loaded from this run's options.
🤖 Generated with Claude Code