Skip to content

init: don't inherit a stale recipesRoot on additive setup #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
data-angel merged 1 commit into from
Oct 15, 2026
Merged

init: don't inherit a stale recipesRoot on additive setup #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/init.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,9 +1417,10 @@ export function deriveUserConfig(
enabledRuntimes: additive ? [...new Set([...(derived.init?.enabledRuntimes ?? []), ...runtimeIds])] : runtimeIds,
keepWarmRuntime: additive ? null : keepWarm,
additive,
...(recipesRoot ? { recipesRoot } : {}),
...(benchmarksRoot ? { benchmarksRoot } : {}),
...(backendCatalogPath ? { backendCatalogPath } : {})
// This run's sources replace the previous init's: recipeId is only valid in its own root.
recipesRoot: recipesRoot || undefined,
benchmarksRoot: benchmarksRoot || undefined,
backendCatalogPath: backendCatalogPath || undefined
};
return preserveEnvBackedSecrets(derived, sourceTemplate);
}
Expand Down
14 changes: 14 additions & 0 deletions test/hear-recipe.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,18 @@ assert.match(next.backends.hear.baseUrl, /^http:\/\/127\.0\.0\.1:\d+\/v1$/);
assert.deepEqual(next.aliases.hear.members, ['hear']);
assert.deepEqual(next.aliases.listen.members, ['hear']);

// An additive init from the default recipes must not inherit an earlier init's
// sources, or `lloom status` resolves the new recipeId in the old recipes root.
const staleSources = {
recipesRoot: '/stale/recipes',
benchmarksRoot: '/stale/benchmarks',
backendCatalogPath: '/stale/backends.json'
};
const restacked = await createInitPlan(
{ ...config, init: { recipeId: 'spark03-cuda-media', ...staleSources } },
{ recipeId: 'lloom-hear', additive: true, modelRoot: '/tmp/lloom-models' }
);
assert.equal(restacked.config.init.recipeId, 'lloom-hear');
for (const key of Object.keys(staleSources)) assert.equal(restacked.config.init[key], undefined, key);

console.log('hear-recipe tests passed');
Loading