fix(ci): read the Node version from .nvmrc instead of pinning it inline - #73
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKNMLCKoVr8Xz1HePmDBXs
CI hardcoded node-version: "20.11.1" while the Dockerfile base image moved to 20.20.2. Dependabot bumps the Dockerfile because that is a docker image tag it manages, but it cannot see a version string in workflow YAML, so the two drifted with nothing to catch it. That drift surfaced on #72: @rstest/core, @rsbuild/core and @rspack/core all require ^20.19.0 || >=22.12.0, which CI's 20.11.1 does not satisfy. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKNMLCKoVr8Xz1HePmDBXs
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drift
pr-ci.ymlhardcodednode-version: "20.11.1". The Dockerfile's base image is on a different track — Dependabot bumps it, because a docker image tag is something it manages, but it cannot see a version string inside workflow YAML. So CI and the image drifted apart with nothing to catch it.That surfaced on #72, where
@rstest/core,@rsbuild/coreand@rspack/coreall declare:CI's Node no longer satisfied what the dependencies asked for.
The change
.nvmrcpinned to 20.20.2, matching the Dockerfile tag Bump the "all-dependencies" group with 2 updates across multiple ecosystems #72 moves to.setup-nodenow usesnode-version-file: .nvmrc, so the version lives in one place andnvm usepicks it up locally too.What this does not fix
#72 also fails on an unrelated Dependabot lockfile bug —
@rstest/core@0.11.12vendors@rspack/core@2.2.2, which needs@module-federation/* ^0.24.1 || ^2.0.0, but the lockfile carries only0.22.0and no nested 2.x tree.npm cireports those six packages as missing from the lock. That needs the PR recreated or the lockfile regenerated, separately from this.Remaining drift
.nvmrcand the Dockerfile tag still have to be moved together by hand — Dependabot updates the image tag but will not touch.nvmrc. This narrows the problem from two places to two places that are now one line apart and commented, rather than one being invisible. Genuinely closing it would mean templating the DockerfileFROMfrom.nvmrcat build time, which is a bigger change than this warrants.🤖 Generated with Claude Code
https://claude.ai/code/session_01XKNMLCKoVr8Xz1HePmDBXs