Fix the ffmpeg-caused errors in EV CI#767
Merged
Merged
Conversation
Changed Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 47 47
Lines 4119 4119
Branches 607 607
=======================================
Hits 3409 3409
Misses 579 579
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- use FedericoCarboni/setup-ffmpeg@v2 which is super fast and reliable - pin it to a specific sha for better security - use EVERYVOICE_VERBOSE_TESTS to activate all verbose tests, including in submodules that don't use stubs, i.e., wav2vec2aligner
- show ffmpeg errors in verbose more and when there is an error - pin the setup-ffmpeg action for better CI safety
18b3419 to
855e2bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Fix CI so that ffmpeg-based test in the w2v submodule work.
Fixes?
For some reason, apt-get installed ffmpeg depends on libblas.so.3 which didn't get installed. It might have been possible to figure out how to install it correctly, but using Federico's ffmpeg action is very reliable, runs faster, and solves the problem.
For the record, the actual error message was:
Feedback sought?
mostly rubber stamping
Priority?
well, pretty high to allow for synching the submodule mains to the EV main
Tests added?
just fixing existing tests
How to test?
See that CI passes, both tests.yml and matrix tests
Confidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/wav2vec2aligner#26