Skip to content

Fix the ffmpeg-caused errors in EV CI#767

Merged
joanise merged 2 commits into
mainfrom
dev.ej/studio-tests-data
Nov 25, 2025
Merged

Fix the ffmpeg-caused errors in EV CI#767
joanise merged 2 commits into
mainfrom
dev.ej/studio-tests-data

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Nov 24, 2025

PR Goal?

Fix CI so that ffmpeg-based test in the w2v submodule work.

Fixes?

For some reason, apt-get installed ffmpeg depends on libblas.so.3 which didn't get installed. It might have been possible to figure out how to install it correctly, but using Federico's ffmpeg action is very reliable, runs faster, and solves the problem.

For the record, the actual error message was:

ffmpeg: error while loading shared libraries: libblas.so.3: cannot open shared object file: No such file or directory

Feedback sought?

mostly rubber stamping

Priority?

well, pretty high to allow for synching the submodule mains to the EV main

Tests added?

just fixing existing tests

How to test?

See that CI passes, both tests.yml and matrix tests

Confidence?

high

Version change?

no

Related PRs?

EveryVoiceTTS/wav2vec2aligner#26

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Nov 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/matrix-tests.yml  61% smaller
  .github/workflows/test.yml  56% smaller
  everyvoice/model/aligner/wav2vec2aligner  0% smaller

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 24, 2025

CLI load time: 0:00.29
Pull Request HEAD: 855e2bc7dd19abf036a33869bc0e42d918e63fc4
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:     10245 |     170430 | everyvoice.cli

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.76%. Comparing base (a04866a) to head (855e2bc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files          47       47           
  Lines        4119     4119           
  Branches      607      607           
=======================================
  Hits         3409     3409           
  Misses        579      579           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, I agree, better to use the published action - thanks @joanise !

 - use FedericoCarboni/setup-ffmpeg@v2 which is super fast and reliable
 - pin it to a specific sha for better security
 - use EVERYVOICE_VERBOSE_TESTS to activate all verbose tests, including in
   submodules that don't use stubs, i.e., wav2vec2aligner
 - show ffmpeg errors in verbose more and when there is an error
 - pin the setup-ffmpeg action for better CI safety
@joanise joanise force-pushed the dev.ej/studio-tests-data branch from 18b3419 to 855e2bc Compare November 25, 2025 15:52
@joanise joanise merged commit 855e2bc into main Nov 25, 2025
9 checks passed
@joanise joanise deleted the dev.ej/studio-tests-data branch November 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants