Dev.ej/studio tests data#26
Merged
Merged
Conversation
errors from ffmpeg were being captured but not printed, so I could not see what they were. In case or error or in verbose mode, let's see them.
Changed Files
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 5 5
Lines 223 223
=======================================
Hits 216 216
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Make it so that errors from ffmpeg are visible in the logs where there is a test failure.
Also add missing permissions to make workflow more secure.
Fixes?
broken w2v unit testing in the EveryVoice CI workflow
Feedback sought?
mostly rubber stamping
Priority?
normal
Tests added?
just fixing existing tests
How to test?
see that CI passes in EV, both tests and matrix-tests
Confidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/EveryVoice#767