Skip to content

Dev.ej/studio tests data#26

Merged
joanise merged 3 commits into
mainfrom
dev.ej/studio-tests-data
Nov 25, 2025
Merged

Dev.ej/studio tests data#26
joanise merged 3 commits into
mainfrom
dev.ej/studio-tests-data

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Nov 24, 2025

PR Goal?

Make it so that errors from ffmpeg are visible in the logs where there is a test failure.

Also add missing permissions to make workflow more secure.

Fixes?

broken w2v unit testing in the EveryVoice CI workflow

Feedback sought?

mostly rubber stamping

Priority?

normal

Tests added?

just fixing existing tests

How to test?

see that CI passes in EV, both tests and matrix-tests

Confidence?

high

Version change?

no

Related PRs?

EveryVoiceTTS/EveryVoice#767

errors from ffmpeg were being captured but not printed, so I could not see what
they were. In case or error or in verbose mode, let's see them.
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Nov 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  aligner/tests/test_cli.py  22% smaller
  .github/workflows/test.yml  0% smaller

@joanise joanise requested a review from roedoejet November 24, 2025 21:44
Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess it was an ffmpeg issue that crashed CI? Thanks @joanise - looks good.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 24, 2025

CLI load time: 0:00.16
Pull Request HEAD: e4311d7e9f37844f8936d8d054095887db17f2c1
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (d4b491f) to head (e4311d7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files           5        5           
  Lines         223      223           
=======================================
  Hits          216      216           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise merged commit e4311d7 into main Nov 25, 2025
7 checks passed
@joanise joanise deleted the dev.ej/studio-tests-data branch November 25, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants