chore(deps-dev): bump eslint-plugin-react-hooks from 4.6.2 to 7.1.1 - #653
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.6.2 to 7.1.1. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/react/react/blob/main/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/eslint-plugin-react-hooks@7.1.1/packages/eslint-plugin-react-hooks) --- updated-dependencies: - dependency-name: eslint-plugin-react-hooks dependency-version: 7.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
birme
left a comment
There was a problem hiding this comment.
Verdict: Needs Changes
Major bump (eslint-plugin-react-hooks 4 -> 7) with all CI checks failing. react-hooks v5+ targets the ESLint 9 flat-config world and changes its recommended ruleset; against the current eslintrc setup it breaks lint. This belongs to the same coordinated ESLint 9/10 migration as #659 and #660 — land them together, not standalone on red CI. Routing to a human / dependency-updater.
birme
left a comment
There was a problem hiding this comment.
Reviewed via daily-backlog-pr (Phase 3.5). This eslint-plugin-react-hooks 4.6.2 → 7.1.1 (three majors) currently fails CI (build/lint/tests red), so it can't be merged as-is — a major-version bump like this needs the accompanying code/flat-config migration before it will pass. Requesting changes until CI is green; a maintainer should either land the migration on this branch or close it in favor of a coordinated upgrade.
birme
left a comment
There was a problem hiding this comment.
Independent review (daily-backlog-pr Phase 3.5, dependabot orphan PR triage).
Verdict: Needs Changes — failing CI
Multiple checks are failing on this dependency bump. Per our merge policy we do not merge with failing CI. Holding until the failures are resolved.
birme
left a comment
There was a problem hiding this comment.
daily-backlog-pr Phase 3.5 — Needs Changes. CI is red across lint/prettier/builds/tests: this is a major-version bump (eslint-plugin-react-hooks 4.6.2 → 7.1.1) with breaking changes, so it can't be adopted as a straight dependency bump. It needs a manual migration (config/flat-config/rule changes) before CI can pass. Leaving open for a maintainer to do the migration rather than merging red or closing a wanted upgrade.
Bumps eslint-plugin-react-hooks from 4.6.2 to 7.1.1.
Release notes
Sourced from eslint-plugin-react-hooks's releases.
Changelog
Sourced from eslint-plugin-react-hooks's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)