chore(deps-dev): bump eslint from 8.57.1 to 10.7.0 - #659
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.7.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.7.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.7.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
birme
left a comment
There was a problem hiding this comment.
Verdict: Needs Changes
This is a two-major bump (ESLint 8 -> 10) and all CI checks fail. ESLint 9+ drops the legacy .eslintrc format and requires flat config (eslint.config.js), plus the removal of many formatting rules and API changes that break the current lint setup — this repo is still on the eslintrc-style config, so a straight version bump cannot pass. This needs a deliberate flat-config migration (coordinated with @typescript-eslint v8 in #660 and eslint-plugin-react-hooks v7 in #653, which are part of the same migration), not an automated Dependabot merge. Routing to a human / the dependency-updater agent to do the ESLint 9/10 migration as one unit. Not merging on red CI.
|
A newer version of eslint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
birme
left a comment
There was a problem hiding this comment.
Reviewed via daily-backlog-pr (Phase 3.5). This eslint 8.57.1 → 10.7.0 (two majors) currently fails CI (build/lint/tests red), so it can't be merged as-is — a major-version bump like this needs the accompanying code/flat-config migration before it will pass. Requesting changes until CI is green; a maintainer should either land the migration on this branch or close it in favor of a coordinated upgrade.
birme
left a comment
There was a problem hiding this comment.
Independent review (daily-backlog-pr Phase 3.5, dependabot orphan PR triage).
Verdict: Needs Changes — failing CI
Multiple checks are failing on this dependency bump. Per our merge policy we do not merge with failing CI. Holding until the failures are resolved.
Bumps eslint from 8.57.1 to 10.7.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
fabd99b10.7.037c5e75Build: changelog update for 10.7.09489379chore: update dependency@eslint/eslintrcto ^3.3.6 (#21076)81a4774chore: updates for v9.39.5 release3e7bf15fix: applyignoreClassesWithImplementsto class expressions (#21069)9835414chore: enable$ExpectTypeannotations in all TypeScript files (#21071)cf2a9bffeat: add errorClassNames option to preserve-caught-error rule (#21032)c30d808docs: Update READMEf8b873afeat: max-nested-callbacks option for constructor callbacks (#21063)72adf6bchore: restrictmarkdownlint-cli2updates in renovate (#21067)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)