Repository navigation
Pin the release toolchain to 1.98 - #192
Merged
Merged
Conversation
Contributor
Release PreviewNext version:
0.4.1 (2026-10-04) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release cut for the glyph fix failed on toolchain drift: the release
workflow installs stable, which resolved to rustc 1.99.0 on the runner,
and 1.99 changed poise's
parent_commandsmethod shape, soctx.parent_commandsfails to compile at two sites(
src/plugin/command.rs:928,:973).The PR-checks workflow was pinned to 1.98 in #184 for a different 1.99 issue
(the
double_must_uselint). This pins_release.ymlthe same way, so thetwo toolchains cannot drift apart again.
Why my local check passed while CI failed
I reproduced locally with
cargo +stable check --release --workspace --all-features --all-targets— clean, because local stable is 1.98.1 andCI's is 1.99.0. They are different compilers. The tell was in CI's own log:
Reading the toolchain version from the failing run's log should have come
before reproducing locally; "stable" does not mean the same thing on both
machines.
Changes
_release.yml:dtolnay/rust-toolchain@stable→@1.98, with a commentnaming the reason and cross-referencing the PR-checks pin.
Notes
Patch Versionstep succeeded before the build failed, sothe version may have moved once already. The re-run should reuse it, not
double-bump.
their first real run.
[no ci], per the maintainer's instruction,so the release actually re-runs and ships.