Filter invalid negative NOAA flood stages in gauge flood-event overlays

[Copilot]

create_flood_events() was plotting invalid NOAA flood-stage values as real flood stages when categories are undefined, which injected bogus threshold lines and distorted the stage axis. This change ensures only valid non-negative numeric flood stages are rendered.

• Flood stage validation in create_flood_events()

  • Rejects missing/invalid stage values before plotting:
    • None
    • empty/whitespace strings
    • non-numeric values
    • any negative stage value (including NOAA placeholder-style values such as -9999 after parsing)

• Consistent rendering values

  • Uses the validated numeric stage_value for shape coordinates (y0, y1) and annotation positioning/text, avoiding raw/unparsed stage values in overlays.

stage = details.get("stage", None)
if stage is None:
    continue

if isinstance(stage, str):
    stage = stage.strip()
    if not stage:
        continue

try:
    stage_value = float(stage)
except (TypeError, ValueError):
    continue

if stage_value < 0:
    continue

[romer8]

no need for this test file

[romer8]

@copilot work on this

[Copilot]

Removed tests/test_gauges.py as requested in commit bd10601.

[romer8]

can we instead make that if ``

Suggested change

	if stage_value == FLOOD_STAGE_PLACEHOLDER:
	if stage_value < 0:
	continue

[Copilot]

Implemented in commit f93e863: the flood-stage filter now skips any negative stage_value (if stage_value < 0: continue).

[romer8]

look my suggestion below

[Copilot]

Addressed via the suggested update in commit f93e863.

[romer8]

@copilot please address the reviewer's response

[Copilot]

@copilot please address the reviewer's response

Addressed in f93e863 (updated flood-stage filter to stage_value < 0). I also checked current review threads and don’t see any additional unresolved reviewer response to implement; share the specific thread if you want a further change.