Skip to content

Filter invalid negative NOAA flood stages in gauge flood-event overlays #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Filter invalid negative NOAA flood stages in gauge flood-event overlays #11

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80be565
Initial plan
Copilot May 18, 2026
fab74ba
fix: skip placeholder flood stage values in flood event annotations
Copilot May 18, 2026
c05a4ba
refactor: use validated flood stage values for plotting
Copilot May 18, 2026
eeb1245
fix: use cleaned validated stage value in annotations
Copilot May 18, 2026
0632146
test: clarify invalid stage test name
Copilot May 18, 2026
062c35e
fix: simplify stage normalization using validated float values
Copilot May 18, 2026
bd10601
chore: remove unneeded gauge test file per review
Copilot May 18, 2026
f93e863
fix: skip all negative flood stage values
Copilot May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 45 additions & 30 deletions ciroh_plugins/nwmps/gauges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,37 +131,52 @@ def create_flood_events(flood_data):

for category, details in categories.items():
stage = details.get("stage", None)
if stage is not None:
shapes.append(
{
"type": "line",
"x0": 0,
"x1": 1,
"xref": "paper",
"y0": stage,
"y1": stage,
"yref": "y1",
"line": {
"color": category_colors.get(category.lower(), "black"),
"width": 2,
"dash": "dash",
},
}
)
if stage is None:
continue

annotations.append(
{
"x": 0,
"y": stage,
"xref": "paper",
"yref": "y1",
"text": f"{stage} {flood_data.get('stageUnits', '')} - {category}".strip(),
"showarrow": False,
"xanchor": "left",
"yanchor": "bottom",
"font": {"color": "black", "size": 12},
}
)
if isinstance(stage, str):
stage = stage.strip()
if not stage:
continue

try:
stage_value = float(stage)
except (TypeError, ValueError):
continue

if stage_value < 0:
continue

shapes.append(
{
"type": "line",
"x0": 0,
"x1": 1,
"xref": "paper",
"y0": stage_value,
"y1": stage_value,
"yref": "y1",
"line": {
"color": category_colors.get(category.lower(), "black"),
"width": 2,
"dash": "dash",
},
}
)

annotations.append(
{
"x": 0,
"y": stage_value,
"xref": "paper",
"yref": "y1",
"text": f"{stage_value:g} {flood_data.get('stageUnits', '')} - {category}".strip(),
"showarrow": False,
"xanchor": "left",
"yanchor": "bottom",
"font": {"color": "black", "size": 12},
}
)

return shapes, annotations

Expand Down