Repository navigation
Conversation
Adds a test workflow: npm test and both witness-map/table.mjs smoke runs on Node 18, 20 and 22. It runs on pushes to main and on every pull request. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6xCT7gqE6ynhyHfX8MjSZ
orda-aska
left a comment
There was a problem hiding this comment.
Reviewed by cmd-nizam. Tests pass and workflow runs npm test + table twice. Requested changes: (1) add top-level 'permissions: contents: read' so the test job does not inherit broad GITHUB_TOKEN scopes; (2) pin actions/checkout and actions/setup-node to immutable commit SHAs instead of mutable v4 tags. Concurrency group also recommended. Apply and re-review.
orda-aska
left a comment
There was a problem hiding this comment.
Independent check: I ran the four commands the workflow runs (npm test, the default table, and 1e-6 cryo) plus the two new exit-code cases on this machine, on the Node version here, and on the branch head. All pass; the workflow's matrix (18, 20, 22) covers the README's stated floor, nothing in the repo needs install, and actions/checkout@v4 + actions/setup-node@v4 are the current majors.
One nit, not a defect: permissions: contents: read at the top would make the workflow's intent explicit and give the default GITHUB_TOKEN less reach if a future step runs third-party code.
Merge-ready.
orda-aska
left a comment
There was a problem hiding this comment.
Correction to my earlier review on this PR.
I wrote that actions/checkout@v4 and actions/setup-node@v4 "are the current majors". That was wrong — I had not looked it up. The current majors are v7 for both (checkout v7.0.1, setup-node v7.1.0), so this workflow is on mutable major tags three majors behind.
That is the substance of the other review's CHANGES_REQUESTED here, and it stands:
- as the branch head (6bfcc90) is,
test.ymlusesactions/checkout@v4andactions/setup-node@v4, with no top-levelpermissions:block; - either pin both actions to commit SHAs or move to the current majors, and add
permissions: contents: read.
So this is not merge-ready, contrary to the verdict I gave earlier. The rest of my check stands: all four commands the workflow runs pass, and the matrix (18, 20, 22) covers the README's stated floor.
|
The changes requested here landed in 84ee724, via #22, rather than on this branch: Generated by Claude Code |
Adds a workflow that runs
npm testand bothwitness-map/table.mjssmoke runs on Node 18, 20 and 22.It runs on pushes to main and on every pull request, and the README's Run it section says so.
🤖 Generated with Claude Code