Skip to content

experiment: test Pokopia photo DMA readback flush (notsapinho build 24) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Framerr merged 2 commits into from
Nov 8, 2026
Merged

experiment: test Pokopia photo DMA readback flush (notsapinho build 24) #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92ef665
experiment: flush Switch 2 DMA image-to-buffer readback for Pokopia p…
Framerr Nov 7, 2026
981b58d
ci: enable read-only Windows test artifacts for GPU experiments
Framerr Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/fork-windows-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ on:
- .github/workflows/fork-windows-check.yml
- .github/workflows/build-windows.yml
- src/CMakeLists.txt
- src/video_core/**
- src/shader_recompiler/**
- src/yuzu/**
- src/yuzu_cmd/**
- src/qt_common/**
Expand Down
16 changes: 16 additions & 0 deletions src/video_core/engines/maxwell_dma.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "video_core/engines/maxwell_dma.h"
#include "video_core/guest_memory.h"
#include "video_core/memory_manager.h"
#include "video_core/nx2.h"
#include "video_core/renderer_base.h"
#include "video_core/textures/decoders.h"

Expand Down Expand Up @@ -203,6 +204,21 @@ void MaxwellDMA::CopyBlockLinearToPitch() {
copy_info.length_y = regs.line_count;
auto& accelerate = rasterizer->AccessAccelerateDMA();
if (accelerate.ImageToBuffer(copy_info, src_operand, dst_operand)) {
// Switch 2 photo captures may read the DMA destination on the CPU before an
// accelerated GPU image-to-buffer copy reaches guest memory. Flush the copied
// region before DMA completion to avoid encoding stale rows.
//
// Experimental port of notsapinho/Eglantine@7dde4f15. Set
// EDEN_NX2_DMA_READBACK_FLUSH=0 to compare against the existing behavior.
static const bool flush_readbacks = [] {
const char* value = std::getenv("EDEN_NX2_DMA_READBACK_FLUSH");
return value == nullptr || value[0] != '0';
}();
if (flush_readbacks && Tegra::g_nx2_ampere.load(std::memory_order_relaxed)) {
memory_manager.FlushRegion(dst_operand.address,
static_cast<size_t>(dst_operand.pitch) * regs.line_count,
VideoCommon::CacheType::BufferCache);
}
return;
}

Expand Down
Loading