Skip to content

experiment: test Pokopia photo DMA readback flush (notsapinho build 24) - #17

Merged
Framerr merged 2 commits into
nx2from
experiment/pokopia-dma-photo-flush
Nov 8, 2026
Merged

Framerr merged 2 commits into
nx2from
experiment/pokopia-dma-photo-flush

Conversation

@Framerr

@Framerr Framerr commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Purpose

Isolate the photo-capture fix from notsapinho/Eglantine commit 7dde4f15, present in build 24. The reporter tested that complete build and observed no corrupted photos and consistent 60 FPS, but build 24 includes other unrelated changes; this PR tests only the DMA readback correction.

Change

  • After successful accelerated ImageToBuffer on Switch 2, flush the destination range from BufferCache to guest memory before DMA completes.
  • Control: EDEN_NX2_DMA_READBACK_FLUSH=0 disables the new flush, allowing A/B comparison.
  • Changes one production file: src/video_core/engines/maxwell_dma.cpp.

Isolation / safeguards

To verify

  • Build only when the reporter requests a test build.
  • Compare 10+ saved photos across multiple game sessions against Frameropia v0.0.2 and notsapinho build 24.
  • Check geometry flicker, saving and FPS.
  • Run same test with EDEN_NX2_DMA_READBACK_FLUSH=0 to confirm causality.

Related issue: #14. Keep main and nx2 intact.

Framerr commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

Reporter validation — approved for integration (2026-11-08)

Tested Windows artifact from run 42427657634: 48 of 50 Pokémon Pokopia saved photos were correct (96%), only 2 of 50 corrupted. Reporter explicitly approves this improvement.

Possible relationship between the remaining failures and shaders compiling during capture is unconfirmed; requires further investigation. This significantly improves results but is not a complete fix. Integrate only this DMA readback correction; keep the still-open photo issue tracked. No new version or release with this merge.

@Framerr
Framerr marked this pull request as ready for review November 8, 2026 00:28
@Framerr
Framerr merged commit 777181d into nx2 Nov 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant