Repository navigation
experiment: test Pokopia photo DMA readback flush (notsapinho build 24) - #17
Merged
Merged
Conversation
This was referenced Nov 7, 2026
Owner
Author
Reporter validation — approved for integration (2026-11-08)Tested Windows artifact from run 42427657634: 48 of 50 Pokémon Pokopia saved photos were correct (96%), only 2 of 50 corrupted. Reporter explicitly approves this improvement. Possible relationship between the remaining failures and shaders compiling during capture is unconfirmed; requires further investigation. This significantly improves results but is not a complete fix. Integrate only this DMA readback correction; keep the still-open photo issue tracked. No new version or release with this merge. |
Framerr
marked this pull request as ready for review
November 8, 2026 00:28
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Isolate the photo-capture fix from notsapinho/Eglantine commit 7dde4f15, present in build 24. The reporter tested that complete build and observed no corrupted photos and consistent 60 FPS, but build 24 includes other unrelated changes; this PR tests only the DMA readback correction.
Change
ImageToBufferon Switch 2, flush the destination range from BufferCache to guest memory before DMA completes.EDEN_NX2_DMA_READBACK_FLUSH=0disables the new flush, allowing A/B comparison.src/video_core/engines/maxwell_dma.cpp.Isolation / safeguards
nx2, not the rejected, photo-regressing PR experiment: isolate Orchid #66 buffer readback fix for Pokopia photos #16.To verify
EDEN_NX2_DMA_READBACK_FLUSH=0to confirm causality.Related issue: #14. Keep
mainandnx2intact.