Repository navigation
Conversation
Owner
Author
Reporter test: severe photo regression — reject this experiment (2026-11-08)The reporter tested the first-photo CPU DMA fallback experiment and reports all saved Pokopia photographs are corrupt. This is much worse than the previous accepted DMA flush behavior (initially 48/50 good, though first-capture corruption remains reproducible). Result: FAIL. Bypassing accelerated |
4 tasks
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Diagnose the reproducible first-capture bug in #14 without undoing the approved DMA flush fix.
Reporter observed 3/3 first photos corrupt across independent restarts, with one second photo corrupt and all third photos correct. A separate rapid-photo test reported one vertically wrapped image.
Experimental change
MaxwellDMA::CopyBlockLinearToPitch, match the expected 1920×1080 RGBA8 image-to-buffer transfer (7680-byte pitch and row length, 1080 rows, supported block-linear source layout).AccessAccelerateDMA().ImageToBuffer()and use the existing CPU unswizzle/readback fallback.FRAMEROPIA_FIRST_PHOTO_DMA_CPU=0disables the test and restores normal behavior.Caveats
This is an A/B diagnostic hypothesis, not a proven fix. The exact shape match may fail if Pokopia uses another pitch/copy geometry; inspect logs before interpreting a negative test. CPU fallback may introduce a temporary slowdown for the initial photographs. No generalized buffer-cache change and no old PR #16 patch.
Validation
Pokopia photo-shaped DMA copy ... fallback=truefor first photoFRAMEROPIA_FIRST_PHOTO_DMA_CPU=0as controlDo not merge without reporter confirmation. Baseline
nx2remains unaffected.