Repository navigation
Conversation
Owner
Author
Reporter validation — rendering regression (2026-11-08)Tested Windows artifact from run 42427848423. Reporter observed no significant performance improvement, all saved photos corrupt, and a severe new sky rendering corruption: bright/intense pink sky. This build adds deferred texture uploads on top of #18, so the sky regression is associated with this combined configuration; do not assert the exact underlying cause without isolation. The photo DMA readback fix #17 was absent, explaining why photo corruption remained possible. Do not merge; close PR. No release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test build C: deferred linear texture upload
Port notsapinho/Eglantine a2042312 on top of the direct linear image upload change being tested in #18. This is a cumulative performance comparison:
nx2baseline (Frameropia v0.0.2)Feature comparison toggle:
EDEN_NX2_DEFER_UPLOADS=0disables deferral. This branch does not include the Pokopia photo fix from #17 or the rejected PR #16.Windows test is handled by
fork-windows-check: artifact only, no GitHub release. Do not merge; verify build, FPS, visual correctness, photos, saving, shader stalls and crashes. Related #15.