Merge Degas2 Simulation Code - #8
Open
Fuad-HH wants to merge 152 commits into
Open
Conversation
# Conflicts: # test/test_degas2_physics.cpp
…UMTally into degas2_physics
…tion position. NEED TO FIX: new issue of particles deleting
-fix kokkos finalization
- Degas2 part is not ready yet. Only the code is merged (copied they compile, but did not run) - All the previous gabe_dg2physics_debug branch error reamains. - Some parts of the branch couldn't be merged or copied to it since had to keep the openmc part intact and working. For example, the multidimensional flux, flection in boundary condition etc. But the functions to achieve these are copied. - Tested that it runs with openmc with 800 particles as before. - Some changes may seem like introduced in this commit but they are actually copied from dg2physics branch since the pumitallyopenmc directory is renamed in a previous commit in main and the files in pumitallyopenmc are not being tracked against pumitally by git.
- Added logging of files to be checked in format-check workflow. - Updated static-analysis workflow to enable DEGAS2 support. - Changed build type to Debug and enabled DEGAS2 and tests in the test workflow.
It is needed because it uses kokkos and other pumipic upstream libraries. All the linkings will be fixed later for coherence.
This is to remove the double job dispatch in pull_requests.
This shouldn't be necessary as it works locally and with spack without any problem. But in CI it says that it cannot find a pumipic shared library. It even worked in CI in main. ``` [ 92%] Linking CXX executable test_pumi_tally_impl_methods /home/runner/work/PumiTally/PumiTally/build/test/test_pumi_tally_impl_methods: error while loading shared libraries: libparticleStructs.so: cannot open shared object file: No such file or directory CMake Error at /home/runner/work/PumiTally/PumiTally/deps/lib/cmake/Catch2/CatchAddTests.cmake:70 (message): Error running test executable '/home/runner/work/PumiTally/PumiTally/build/test/test_pumi_tally_impl_methods': ```
- Changed trigger from push to workflow_run, depending on the completion of the Test workflow. - Added conditional execution for the clang-tidy job based on the event type and conclusion. - Updated checkout step to reference the correct commit SHA from the workflow run.
- Updated format-check and test workflows to trigger on push and pull_request events for the main branch. - Modified static-analysis workflow to simplify the conditional execution based on test workflow_run success.
- Initialized the variance variable `varux` to 0.0 . - Updated the tolerance for the test on variable `l`, `sdl` to 0.0015, reflecting a more accurate confidence interval for 1000 samples.
Fuad-HH
force-pushed
the
merge_gabe
branch
2 times, most recently
from
April 30, 2026 19:00
a68751f to
ef1e695
Compare
other methods may use it later.
- Updated function names to follow CamelCase. - Changed parameter types in function signatures to use references for efficiency. Although most of them are called only once. - Refactored InputParameter struct and make the reader a constructor for better structure. - Added some todos for the next commit.
replace reading to vector with hostwrite, writetag function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This degas2 application will work as a proof of concept.