Feature: make fields allowed to update configureable per doc type#29
Merged
Feature: make fields allowed to update configureable per doc type#29
Conversation
bh0fer
approved these changes
Jan 6, 2025
Contributor
Author
|
@SilasBerger fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current behavior
A user can update the
datafield od a document with any data as long as he hasRWaccess. No other fields are updateable.issue
Some documents, as for example
fileordirshould be allowed to update theirparent_idsolution
A new model
allowed_actionis introduxed, which has two columns:document_typedescribes thetypeof a documentactiondescribes the allowed action which can be performed for a documentLike that we have a generic solution to configure the api in a dynamic way.
The migration adds two default records:
dirupdate@parent_idfileupdate@parent_idThe advantage of this solution in comparison to a "static check" in the background is, that conceptual, it is a "client application concerne", so when the frontend implements a new document type that needs to update the "parent_id" aswell, the backend does not need to be updated at all...
Anyway, the api is responsible to correctly parse and interpret the
actionfield - in this case, a doc. can be relinked to another parent doc. when the action is specified asupdate@parent_idfor a given document type.