Simple Cleanups#61
Conversation
…vide a copy of the GPL alongside the LGPL document. See section 4b of the LGPL document: "Accompany the Combined Work with a copy of the GNU GPL and this license document"
… general LPGL license terms in the README, I think.
Nikolay-Sitnikov
added
the
Enhancement
Glease
left a comment
Glease
left a comment
There was a problem hiding this comment.
relicense to GPL without notice is not going to work
Glease
left a comment
Glease
left a comment
There was a problem hiding this comment.
actually, never mind. I see what you mean. TIL
|
ok I remember why we were stuck with primitive java syntax. the javadoc generator is from java 11 so it doesn't really support the nice syntax sugars from newer java. I like the frames so I kinda want to stay with it... |
|
Surely we can find a modern Javadoc generator to use in our buildscript? CC @eigenraven - Do you know if this is easily possible? |
Well, https://github.com/climber09/Javadoc-Frames-Generator/tree/master exists. Unfortunately, it'd be a massive pain to run in our buildscript as-is. |
|
If we need java 25 directly in the dev env, we can always enable jvmdowngrader in the buildscript and get away with it. |
Java 25 doesn't have framed Javadocs either (although they're apparently much better than the old non-framed Javadocs), and we can enable Java 25 for the Javadoc task individually in the buildscript anyways. |
|
@Glease Would you be alright with modern Java 25 javadocs? |
|
In the end i'll not be the one who read the doc, so a dev vote feels appropriate. please build an example of java 25 doc and get the pipeline to build it, then we can do a proper vote |
4 participants
Cleans up the code a tiny bit, moving comments around, removing some
@SuppressWarningsand some unused code, and using modern Java features.These changes should require no modifications to any outside mods.