Skip to content

deps: transformers 5.17.0 (Qwen 3.5), with openpi's patch ported - #647

Closed
RyanPCo wants to merge 1 commit into
ryanco/text-feature-cachefrom
ryanco/transformers-upgrade
Closed

RyanPCo wants to merge 1 commit into
ryanco/text-feature-cachefrom
ryanco/transformers-upgrade

Conversation

@RyanPCo

@RyanPCo RyanPCo commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Qwen 3.5 exists only from transformers 5.2.0, so the 4.53.2 pin cannot
stay; pin 5.17.0 (latest stable). The pin exists for openpi's
transformers_replace patch, whose files are verbatim copies of
transformers sources, so the two move together: the port and the
pi0.5-side 5.x fixes are in the submodule bump (openpi a385735 on
ryanco/transformers-5, not yet pushed).

egomimic side:

  • from_pretrained(torch_dtype=) -> dtype= in the Qwen3 text stem and
    the two embedding-process scripts.
  • hermetic_env no longer patches transformers.utils.hub._is_offline_mode
    unconditionally: 5.x dropped it and calls huggingface_hub.is_offline_mode(),
    which reads the constant we already patch.
  • pi_unavailable also requires config.json in the HF cache: 5.x resolves
    the tokenizer class through the model config, so the tokenizer files alone
    are no longer enough (the cached google/paligemma-3b-mix-224 entry was
    missing it; fetched once online).
  • New tests/unit/test_transformers_upgrade.py: the installed version
    matches the pyproject pin, transformers.models.qwen3_5 imports, and
    the openpi patch is actually installed (tuple-returning GemmaRMSNorm,
    the AdaRMS config fields, check(), embed_scale == 1).

Resolved transitive moves: tokenizers 0.21.4 -> 0.23.2, huggingface-hub
0.36.2 -> 1.31.0, safetensors 0.8.0 unchanged. torch, numpy, datasets,
timm and lightning are untouched.

The shared emimic venv is NOT upgraded by this branch; until it is, run
this branch against /coc/flash7/rco3/EgoVerse-wt/venvs/transformers-upgrade.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

RyanPCo commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@RyanPCo
RyanPCo changed the base branch from ryanco/text-encoder-fixes to graphite-base/647 September 16, 2026 17:22
@RyanPCo
RyanPCo changed the base branch from graphite-base/647 to ryanco/text-encoder-fixes September 16, 2026 17:22
@RyanPCo
RyanPCo changed the base branch from ryanco/text-encoder-fixes to graphite-base/647 September 16, 2026 17:23
@RyanPCo
RyanPCo changed the base branch from graphite-base/647 to ryanco/text-encoder-fixes September 16, 2026 17:23
@RyanPCo
RyanPCo changed the base branch from ryanco/text-encoder-fixes to graphite-base/647 September 16, 2026 17:25
@RyanPCo
RyanPCo changed the base branch from graphite-base/647 to ryanco/text-encoder-fixes September 16, 2026 17:25
@RyanPCo
RyanPCo changed the base branch from ryanco/text-encoder-fixes to graphite-base/647 September 16, 2026 17:30
@RyanPCo
RyanPCo force-pushed the ryanco/transformers-upgrade branch from 5ac62d2 to ca14e40 Compare September 16, 2026 17:30
@RyanPCo
RyanPCo changed the base branch from graphite-base/647 to ryanco/text-feature-cache September 16, 2026 17:30
@RyanPCo
RyanPCo force-pushed the ryanco/text-feature-cache branch from 09cfe20 to a8b6490 Compare September 17, 2026 14:52
@RyanPCo RyanPCo closed this Sep 19, 2026
This was referenced Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant