Repository navigation
ingest: tie labs to vendors, close the login redirect bypass, narrow job writes - #760
Draft
SaveAanchal wants to merge 1 commit into
Draft
SaveAanchal wants to merge 1 commit into
SaveAanchal wants to merge 1 commit into
Conversation
…job writes Needed before any vendor gets a login. - Labs: onboarding records which labs a vendor may deliver for (--lab, required). A conversion job rejects any other lab before storing a stage or diff, and hand-off checks again from the pin. A vendor with no registered labs delivers nothing. - Redirects: login `next` and bulk decide `back` go through views.safe_target, which refuses control characters, backslashes, and anything with a scheme or host. /login?next=/%09/evil.com used to leave the site. - Job writes: pipeline/jobs/ and pipeline/staged/ move to their own bucket, egoverse-ingest-jobs (--jobs-bucket), so a job's key needs write access nowhere else: not accounts, decisions, status or rldb. The README lists each key's access and the risk that remains. The R2 tokens themselves have not been created or tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes from the review:
onboard --lab); other labs are rejected before anything is stored and checked again at hand-off.egoverse-ingest-jobs, so a compromised job can't reach accounts, decisions or Lance. The remaining risk is inegomimic/ingest/aws/README.md.Tested: unit tests.
Not tested: the real R2 tokens and the new bucket, which don't exist yet.
🤖 Generated with Claude Code