Repository navigation
Conversation
The test raced 8 goroutines against a 2 ms sleep. On a slow macOS race runner a call could start after the first run had finished, a legitimate second run, and the test failed with 6 collects instead of 3. The fake collector now parks on a gate that the test closes only after the other 7 calls have returned, so exactly one run is open while they try.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
Held so it ships in the same release as the proxied-copy device ID fix: auto-tag runs on any .go change, so merging this test-only change alone would cut a release with nothing user-facing in it. Its commit is carried into that PR. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCollectAllSingleFlightfailed on #272's macOS race run with "total collects = 6, want 3", on a PR that changed no Go code. The test started 8 goroutines callingcollectAlland relied on a 2 ms sleep per collect to keep the first run open. On a slow runner one goroutine started only after that run had finished. That is a legitimate second run, because the guard rejects overlapping runs and not later ones.The fake collector now has a
gatechannel that parks every collect. The test closes it only after the other 7 calls have returned. A call can only return while the gate is shut by bailing on the guard, so at that point exactly one run is open. The timing guess is gone. The unusedholdsleep is removed.Checked on a separate machine:
go test -race -count=50 -run 'TestCollectAllSingleFlight$' .passes.CompareAndSwapdisabled, the test fails with "single-flight violated: only 0 of 7 calls bailed while one run was in progress".go test -race .andgo vet .pass.