Skip to content

OnlineServices: Pass LobbyMemberEntry by const reference in PlayerDoesntHaveMap callback - #170

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/optimize-lobby-callback
Open

OnlineServices: Pass LobbyMemberEntry by const reference in PlayerDoesntHaveMap callback#170
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/optimize-lobby-callback

Conversation

@seer-by-sentry

Copy link
Copy Markdown

Fixes CLIENT-14C. The issue was that: Access violation in LobbyMemberEntry::operator= caused by passing a corrupted or invalid object within an asynchronous HTTP completion callback.

  • Updated the signature of the PlayerDoesntHaveMap callback (m_cbPlayerDoesntHaveMap) and its registration function to pass LobbyMemberEntry by constant reference instead of by value.
  • Updated the corresponding callback registration lambda in WOLGameSetupMenu.cpp to match the new constant reference signature.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 7919851

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants