Skip to content

OnlineServices: Pass LobbyMemberEntry by const reference in PlayerDoesntHaveMap callback #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

OnlineServices: Pass LobbyMemberEntry by const reference in PlayerDoesntHaveMap callback #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ralsMD/Code/GameEngine/Include/GameNetwork/GeneralsOnline/OnlineServices_LobbyInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,8 @@ class NGMP_OnlineServices_LobbyInterface

void UpdateRoomDataCache(std::function<void(void)> fnCallback = nullptr);

std::function<void(LobbyMemberEntry)> m_cbPlayerDoesntHaveMap = nullptr;
void RegisterForPlayerDoesntHaveMapCallback(std::function<void(LobbyMemberEntry)> cb)
std::function<void(const LobbyMemberEntry&)> m_cbPlayerDoesntHaveMap = nullptr;
void RegisterForPlayerDoesntHaveMapCallback(std::function<void(const LobbyMemberEntry&)> cb)
{
m_cbPlayerDoesntHaveMap = cb;
}
Expand Down
2 changes: 1 addition & 1 deletion GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,7 +1774,7 @@ void WOLGameSetupMenuInit( WindowLayout *layout, void *userData )
}

// player doesnt have map events
pLobbyInterface->RegisterForPlayerDoesntHaveMapCallback([](LobbyMemberEntry lobbyMember)
pLobbyInterface->RegisterForPlayerDoesntHaveMapCallback([](const LobbyMemberEntry& lobbyMember)
{
// tell the host the user doesn't have the map
UnicodeString mapDisplayName;
Expand Down
Loading