Skip to content

TextureLoader: Add validity checks for D3DTexture before operations #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

TextureLoader: Add validity checks for D3DTexture before operations #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@
//Figure out correct reduction
int reqReduction=WW3D::Get_Texture_Reduction(); //requested reduction

if (reqReduction >= mip_count)

Check warning on line 1331 in GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32-debug+e 

 '>=': signed/unsigned mismatch

Check warning on line 1331 in GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32-profile+e 

 '>=': signed/unsigned mismatch

Check warning on line 1331 in GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32+e 

 '>=': signed/unsigned mismatch
reqReduction=mip_count-1; //leave only the lowest level

//Clamp reduction
Expand Down Expand Up @@ -1365,7 +1365,7 @@
//Figure out correct reduction
int reqReduction=WW3D::Get_Texture_Reduction(); //requested reduction

if (reqReduction >= mip_count)

Check warning on line 1368 in GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32-debug+e 

 '>=': signed/unsigned mismatch

Check warning on line 1368 in GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32-profile+e 

 '>=': signed/unsigned mismatch

Check warning on line 1368 in GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/textureloader.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32+e 

 '>=': signed/unsigned mismatch
reqReduction=mip_count-1; //leave only the lowest level

//Clamp reduction
Expand Down Expand Up @@ -1532,6 +1532,11 @@
#endif
);

// Verify texture creation succeeded
if (!D3DTexture) {
return false;
}

MipLevelCount = mip_level_count;

return true;
Expand Down Expand Up @@ -1627,6 +1632,11 @@
#endif
);

// Verify texture creation succeeded
if (!D3DTexture) {
return false;
}

return true;
}

Expand Down Expand Up @@ -1777,6 +1787,12 @@

void TextureLoadTaskClass::Lock_Surfaces(void)
{
// Defensive check: verify D3DTexture is valid before dereferencing
if (!D3DTexture) {
WWASSERT(D3DTexture);
return;
}

MipLevelCount = D3DTexture->GetLevelCount();

for (unsigned int i = 0; i < MipLevelCount; ++i)
Expand Down
Loading