Update#6
Merged
Merged
Conversation
* navigation profile specific voiceinstruction placement * fix: hiking should have been walking * fix: try to find a mapbox profile for the graphhopper profile * Revert "fix: try to find a mapbox profile for the graphhopper profile" This reverts commit 3db1c5b. * feat: configure DistanceConfig from Profile hints too * chore: add myself (Karol Olszacki) to the contributors list * fix: create NavigationTransportMode enum and use that * fix: make sure we accept all kinds of values for wider compatibility with OSRM/Mapbox/etc * fix: DistanceConfig enhancement (#6) * fix: fold more cases into DistanceConfig, remove the new enum and allow usage of existing one * chore: update the example with gh-centric terms --------- Co-authored-by: Karol Olszacki <karol.olszacki@pl.bosch.com>
…opper#3176) * fix: enable last intersection of last step of via points * fix: accidenteley removed modifier * Improve ferry instructions (graphhopper#3179) * announce ferry in instructions * extra instruction sign needed * Update maps to 34acd30e * fix * ensure never NPE * use mode==ferry for mapbox response * fix: enable last intersection of last step of via points * fix: typo * fix: depart and arrival at the same last step at end * fix: comment * chore: formatting using editorconfig --------- Co-authored-by: Peter <graphhopper@gmx.de>
…out dangerous sections
* Trunk roads are not generally toll roads in Austria fixes graphhopper#3190 * fully drop fallbacks for Austrian toll roads Trunk roads are typically toll free, except if explicitly tagged. And motorways are all explicitly tagged already (minor exceptions: some very short sections exactly on some border crossings to Germany) see also graphhopper#3190 (comment)
…ixes graphhopper#3186, graphhopper#3199 Co-authored-by: ratrun <ratrun@gmx.at>
* initial working state. fix for graphhopper#733 * move most of the turn cost config into new turn_time statements * support to specify "add":"Infinity" * rename 'turn time' to 'turn weight' * minor fix * turn_weight is only possible when turn_costs is configured * by default allow the turn_weight feature only on server-side * minor simplify * 'add' for speed is ok * minor comment * removed TODO NOW * delete file * for now no negative adds * minor * improvements and review comments * slightly reduce EdgeBasedNodeContractor.Params.maxPollFactorHeuristic to slightly reduce CH prep time without much query speed slow down * rename turn_weight to turn_penalty * readd bike_tc as might be usefull illustration too * move allow_turn_penalty_in_request into TurnCostsConfig and some minor fixes to custom models * add docs * minor
* use my branch and graphhopper#3122 * slightly faster * test unknown value and conditional with time only (regarding graphhopper#3168)
…3205) * find the point list in real world * use full (2D) distance for averageSlope * fix imports * comment fix
* fix wrong mode in navigation steps * update CONTRIBUTORS.md * remove superflouos access specifier * Clean up DistanceConfigTest * further clean up tests --------- Co-authored-by: charlie <charlielovespythia@virtuals> Co-authored-by: Peter <graphhopper@gmx.de>
* separate path and track tests * minor test change * rename pushingSectionsHighways; remove steps from it and make identical for all bike types * do not change speed of 'path' for racingbike or mtb * racingbike should have same preference for official bike routes * simplify code but not yet there * simplify * revert change in RacingBikePriorityParser; use value=18 in test * tmp * revert and lower speed for bicycle=yes and footway; also racingbike should use consistent speed for cycleway; BikeCustomModelTest is meaningless if priority is 0 * show changes when we skip for all bike types * Revert "show changes when we skip for all bike types" This reverts commit 8f77c3f. * use bike route as 'bike=designated' indicator * add test that is inconsistent in master * track: assume bicycle=yes even if bicycle tag is missing * ground surface: a bit faster for mtb * add comment * ground is too vague -> reduce; more consistent mtb speed increase for certain surfaces * rcbike: important highways at 20km/h * remove test * mtb: speed boost for gravel+pebblestone * mtb: minor consistency change
* bike types: no difference for route networks * minor * revert test
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read our contributing guide and note that also your contribution falls under the Apache License 2.0 as outlined there.
Your first contribution should include a change where you add yourself to the CONTRIBUTORS.md file.