Fixed imprecise assertions - #952
Merged
Merged
Conversation
🤖 Augment PR SummarySummary: This PR improves test precision in the reporting serializer test suite. Changes:
Technical Notes: These changes are test-only and should not affect runtime behavior; they mainly improve assertion semantics and failure messages. 🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens unit test assertions in the reporting serializer test suite to use more precise unittest helpers, improving failure messages and intent clarity while keeping behavior unchanged.
Changes:
- Replaced
assertTrue("<key>" in dict)withassertIn(...)for membership checks. - Replaced
assertTrue(x is not None)withassertIsNotNone(...)for null checks. - Updated a nested assertion in findings validation to use
assertIn(...).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
=======================================
Coverage 92.19% 92.20%
=======================================
Files 444 444
Lines 33957 33957
=======================================
+ Hits 31308 31309 +1
+ Misses 2649 2648 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed imprecise assertions in recently adjusted test cases.