Skip to content

Fixed imprecise assertions #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrismaddalena merged 1 commit into from
Jul 28, 2026
+17 −17
Merged

Fixed imprecise assertions #952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions ghostwriter/reporting/tests/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,20 +134,20 @@ def test_expected_json_keys_exist(self):
report_json = json.loads(report_json)

# Check expected keys are present
self.assertTrue("report_date" in report_json)
self.assertTrue("project" in report_json)
self.assertTrue("client" in report_json)
self.assertTrue("team" in report_json)
self.assertTrue("objectives" in report_json)
self.assertTrue("targets" in report_json)
self.assertTrue("scope" in report_json)
self.assertTrue("deconflictions" in report_json)
self.assertTrue("infrastructure" in report_json)
self.assertTrue("findings" in report_json)
self.assertTrue("docx_template" in report_json)
self.assertTrue("pptx_template" in report_json)
self.assertTrue("company" in report_json)
self.assertTrue("totals" in report_json)
self.assertIn("report_date", report_json)
Comment thread
chrismaddalena marked this conversation as resolved.
self.assertIn("project", report_json)
self.assertIn("client", report_json)
self.assertIn("team", report_json)
self.assertIn("objectives", report_json)
self.assertIn("targets", report_json)
self.assertIn("scope", report_json)
self.assertIn("deconflictions", report_json)
self.assertIn("infrastructure", report_json)
self.assertIn("findings", report_json)
self.assertIn("docx_template", report_json)
self.assertIn("pptx_template", report_json)
self.assertIn("company", report_json)
self.assertIn("totals", report_json)

def test_extra_values(self):
report_json = JSONRenderer().render(self.serializer.data)
Expand Down Expand Up @@ -178,7 +178,7 @@ def test_extra_values(self):
self.assertEqual(totals["objectives_completed"], completed_objectives)

for f in report_json["findings"]:
self.assertTrue("ordering" in f)
self.assertIn("ordering", f)

def test_report_fixture_has_deliberate_variants(self):
finding_severities = set(
Expand Down Expand Up @@ -222,11 +222,11 @@ def test_values_are_not_empty(self):
report_json = json.loads(report_json)

for key in report_json:
self.assertTrue(report_json[key] is not None)
self.assertIsNotNone(report_json[key])

for log in report_json["logs"]:
for entry in log["entries"]:
self.assertTrue(entry["tool"] is not None)
self.assertIsNotNone(entry["tool"])

def test_team_entries_are_ordered_by_role_position_then_operator_name(self):
project = ProjectFactory()
Expand Down
Loading