Repository navigation
feat: infer intermediate quantities through fields and properties - #19
Merged
Merged
Conversation
ScottishTapWater
enabled stacked auto-merge (squash)
October 24, 2026 18:04
stacked auto-merge was automatically disabled
October 24, 2026 18:06
Auto-merge was disabled for another pull request in the stack
ScottishTapWater
added a commit
that referenced
this pull request
Oct 24, 2026
## Stack Slice 4 of 6, based on #19. Review against `feat/discovery-members`. ## Summary Follow selected method and local-function returns across files, including expression bodies, consistent block-body returns and reduced extension calls. Ignore nested functions' returns and preserve overload selection, cycle protection and declared-type validation. Async/iterator inference is outside this slice. ## Verification - Build: zero warnings/errors; Roslyn: 377 passing. - Formatting and diff checks clean. - Independent production and test reviews completed; extension-call finding fixed with regressions and re-reviewed. - Covers overload ambiguity, nested functions/lambdas, conflicting returns and cross-file edits. - Adds the spike's star/delta winding loss and resistance roundtrip acceptance cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Slice 3 of 6, based on #18. Review against
feat/discovery-branches.Summary
Follow field/property initialisers and expression-bodied getters to infer unresolved intermediate quantities, including cross-file and instance member access. Extract declaration eligibility, symbol caching and cycle detection into a focused resolver; expression analysis uses each declaration's semantic model.
Verification