Repository navigation
feat: follow intermediate quantity results through helper methods - #20
Merged
Merged
Conversation
ScottishTapWater
enabled stacked auto-merge (squash)
October 24, 2026 18:04
stacked auto-merge was automatically disabled
October 24, 2026 18:06
Auto-merge was disabled for another pull request in the stack
ScottishTapWater
added a commit
that referenced
this pull request
Oct 24, 2026
## Summary Stack 5 of 6, based on #20. - Parse canonical generated quantity names, including rational powers, using the dimensional model. - Discover unresolved simple type names in parameters, public API signatures and collection declarations. - Let those quantities participate in arithmetic without a producing initializer, including default values and collection elements. - Preserve existing symbols and explicit aliases; reject qualified unresolved names and unrelated indexer result types. - Keep parsing, source discovery and generation planning separate. ## Verification - Solution build: no warnings or errors. - Core tests: 471 passed. - Full Roslyn suite: 409 passed before final review regressions; focused final regression runs passed (16, 10 and 5 cases). - Format verification and `git diff --check` passed. - Independent C# production and test reviews, followed by fixes and re-review. The next PR adds referenced-assembly discovery and package interoperability coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Slice 4 of 6, based on #19. Review against
feat/discovery-members.Summary
Follow selected method and local-function returns across files, including expression bodies, consistent block-body returns and reduced extension calls. Ignore nested functions' returns and preserve overload selection, cycle protection and declared-type validation. Async/iterator inference is outside this slice.
Verification