Skip to content

Fix LV2 microVersion field to use integer instead of string #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix LV2 microVersion field to use integer instead of string #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106291d
Initial plan
Copilot Nov 24, 2025
32ba506
Fix LV2 TTL version to use integer for microVersion
Copilot Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions _codeql_detected_source_root
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.
1 change: 1 addition & 0 deletions src/common/version.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#define SUB_VERSION_INT @SURGE_SUB_VERSION@

#define RELEASE_NUMBER_STR "@SURGE_RELEASE_NUMBER@"
#define RELEASE_NUMBER_INT @SURGE_RELEASE_NUMBER@
#define RELEASE_STR "@SURGE_RELEASE_VERSION@"
#define BUILD_NUMBER_STR "@SURGE_BUILD_HASH@" // Build number to be sure that each result could identified.

Expand Down
2 changes: 1 addition & 1 deletion src/lv2/SurgeLv2Export.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ void lv2_generate_ttl(const char* baseName)

// TODO LV2: implement an adequate version number scheme. For now, make it the last two (so 1.6.2 gets 6 2)
osDsp << " lv2:minorVersion " << SUB_VERSION_INT << " ;\n"
" lv2:microVersion " << RELEASE_NUMBER_STR << " .\n";
" lv2:microVersion " << RELEASE_NUMBER_INT << " .\n";
}

{
Expand Down