Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/ by oleg68 · Pull Request #2635 · GrandOrgue/grandorgue

oleg68 · 2026-09-22T13:56:35Z

Summary

Pure file move: GOSoundResample and GOSoundOnePoleFilter are stateless DSP primitives already consumed from multiple areas of the sound engine (playing/, reverb/) but lived in inconsistent locations (sound/playing/ and bare sound/).
Moves both into a new sound/dsp-kernels/ directory that states the actual dependency rule: depends on nothing, depended on by everything above it.
Updates all include paths, CMakeLists.txt, and CLAUDE.md's directory documentation accordingly.
No logic change.

Test plan

Build clean in build/current (Debug, GO_BUILD_TESTING=ON) with LANG=C make -k -j16
./bin/GOTestExe passes (GOTestSoundOnePoleFilter... N/A upstream; GOTestSoundStream and all other suites pass; the two GOTestPerfSoundBufferMutable/GOTestPerfSoundBufferPlanarMutable failures are pre-existing, unrelated Debug perf-baseline misses)
git diff scoped to renames, include-path updates, build-file entries, and doc comments only

🤖 Generated with Claude Code

codecov-commenter · 2026-09-22T14:05:27Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.75%. Comparing base (79e1142) to head (d575cad).
⚠️ Report is 8 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2635      +/-   ##
==========================================
+ Coverage   31.96%   33.75%   +1.78%     
==========================================
  Files         524      529       +5     
  Lines       27082    27664     +582     
==========================================
+ Hits         8657     9337     +680     
+ Misses      18425    18327      -98

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Review feedback on PR GrandOrgue#2635 (github.com/GrandOrgue/pull/2635, this fork's PR #10) pointed out that GOSoundOnePoleFilter includes sound/buffer/GOSoundBufferMutable.h and exposes it in FilterState:: ProcessBuffer, which the previous "depend on nothing else in the sound engine" wording flatly contradicted. That dependency predates this PR (it was already there in sound/GOSoundOnePoleFilter.h) and is not something a pure file-move PR should be fixing by restructuring the class - buffer/ is itself a dependency-free leaf (a plain data wrapper, verified by its own includes), so depending on it does not actually put a framework or model dependency into dsp-kernels/. Documents that as the one allowed exception instead of overclaiming zero dependencies. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved GOSoundResample/GOSoundOnePoleFilter into sound/dsp-kernels/, but was branched from upstream/master, which lacks sound/effects/ and sound/mappers/ entirely - so it could not update the two consumers that exist only on this branch: GOSoundShelfFilterProcessor.h and GOTestSoundEnclosureShelfMapper.cpp. This is the remainder of that same include-path fix, scoped to what this branch actually has. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together they are exactly PR 1 as it applies here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved the test's target class into sound/dsp-kernels/ but had no test-file move to make, since this test does not exist on upstream/master yet - it was added later on this branch. This is that missing test-file move, done to match the source move exactly: mirrored path, plus the CMakeLists.txt and GOTestExe.cpp registration updates. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together with the preceding include-fix commit, they complete PR 1 as it applies to this branch. Build clean in build/current (Debug, GO_BUILD_TESTING=ON); ./bin/GOTestExe passes GOTestSoundOnePoleFilter, GOTestSoundShelfFilterProcessor and GOTestSoundEnclosureShelfMapper. The GOTestPerfSoundBufferMutable/ GOTestPerfSoundBufferPlanarMutable failures are pre-existing, unrelated Debug perf-baseline misses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) wrote the sound/ directory breakdown from upstream/master, which has neither directory - both exist only on this branch (GOSoundShelfFilterProcessor, GOSoundEnclosureShelfMapper). Filling in the two entries the cherry-picked text couldn't know about, and sharpening the placement rule to name them directly instead of the vaguer "model-aware layer above processing/" wording that stood in for them. Squash into the PR GrandOrgue#2635 cherry-pick commit once this branch is rebased past GrandOrgue#2635's merge, together with the two preceding commits - the three together are PR 1 as it applies to this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

oleg68 · 2026-09-28T06:35:58Z

@larspalo @rousseldenis Could you approve this pr?

PR GrandOrgue#2635 (GrandOrgue#2635) moved GOSoundResample/GOSoundOnePoleFilter into sound/dsp-kernels/, but was branched from upstream/master, which lacks sound/effects/ and sound/mappers/ entirely - so it could not update the two consumers that exist only on this branch: GOSoundShelfFilterProcessor.h and GOTestSoundEnclosureShelfMapper.cpp. This is the remainder of that same include-path fix, scoped to what this branch actually has. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together they are exactly PR 1 as it applies here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved the test's target class into sound/dsp-kernels/ but had no test-file move to make, since this test does not exist on upstream/master yet - it was added later on this branch. This is that missing test-file move, done to match the source move exactly: mirrored path, plus the CMakeLists.txt and GOTestExe.cpp registration updates. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together with the preceding include-fix commit, they complete PR 1 as it applies to this branch. Build clean in build/current (Debug, GO_BUILD_TESTING=ON); ./bin/GOTestExe passes GOTestSoundOnePoleFilter, GOTestSoundShelfFilterProcessor and GOTestSoundEnclosureShelfMapper. The GOTestPerfSoundBufferMutable/ GOTestPerfSoundBufferPlanarMutable failures are pre-existing, unrelated Debug perf-baseline misses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) wrote the sound/ directory breakdown from upstream/master, which has neither directory - both exist only on this branch (GOSoundShelfFilterProcessor, GOSoundEnclosureShelfMapper). Filling in the two entries the cherry-picked text couldn't know about, and sharpening the placement rule to name them directly instead of the vaguer "model-aware layer above processing/" wording that stood in for them. Squash into the PR GrandOrgue#2635 cherry-pick commit once this branch is rebased past GrandOrgue#2635's merge, together with the two preceding commits - the three together are PR 1 as it applies to this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved GOSoundResample/GOSoundOnePoleFilter into sound/dsp-kernels/, but was branched from upstream/master, which lacks sound/effects/ and sound/mappers/ entirely - so it could not update the two consumers that exist only on this branch: GOSoundShelfFilterProcessor.h and GOTestSoundEnclosureShelfMapper.cpp. This is the remainder of that same include-path fix, scoped to what this branch actually has. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together they are exactly PR 1 as it applies here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved the test's target class into sound/dsp-kernels/ but had no test-file move to make, since this test does not exist on upstream/master yet - it was added later on this branch. This is that missing test-file move, done to match the source move exactly: mirrored path, plus the CMakeLists.txt and GOTestExe.cpp registration updates. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together with the preceding include-fix commit, they complete PR 1 as it applies to this branch. Build clean in build/current (Debug, GO_BUILD_TESTING=ON); ./bin/GOTestExe passes GOTestSoundOnePoleFilter, GOTestSoundShelfFilterProcessor and GOTestSoundEnclosureShelfMapper. The GOTestPerfSoundBufferMutable/ GOTestPerfSoundBufferPlanarMutable failures are pre-existing, unrelated Debug perf-baseline misses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) wrote the sound/ directory breakdown from upstream/master, which has neither directory - both exist only on this branch (GOSoundShelfFilterProcessor, GOSoundEnclosureShelfMapper). Filling in the two entries the cherry-picked text couldn't know about, and sharpening the placement rule to name them directly instead of the vaguer "model-aware layer above processing/" wording that stood in for them. Squash into the PR GrandOrgue#2635 cherry-pick commit once this branch is rebased past GrandOrgue#2635's merge, together with the two preceding commits - the three together are PR 1 as it applies to this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

rousseldenis · 2026-10-01T11:40:28Z

@oleg68 You need to rebase

They are stateless DSP primitives already consumed from three different areas (playing/, processing/'s future clients, and reverb/), but lived in sound/playing/ and bare sound/ respectively, misrepresenting them as playback- or engine-scoped rather than shared computational cores. This is a pure file move: give them a directory whose name states the actual dependency rule (depends on nothing, depended on by everything above it) before any more consumers accrete on the old, misleading locations. CLAUDE.md's Main Source Directories section is updated to describe the now-multi-part sound/ layout and the placement rule this move follows. The dsp-kernels/ directory rule is documented once in CLAUDE.md, so the moved headers carry a short doc comment about the class itself rather than restating the directory rule per-header, which would duplicate and drift as new consumers appear. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved GOSoundResample/GOSoundOnePoleFilter into sound/dsp-kernels/, but was branched from upstream/master, which lacks sound/effects/ and sound/mappers/ entirely - so it could not update the two consumers that exist only on this branch: GOSoundShelfFilterProcessor.h and GOTestSoundEnclosureShelfMapper.cpp. This is the remainder of that same include-path fix, scoped to what this branch actually has. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together they are exactly PR 1 as it applies here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved the test's target class into sound/dsp-kernels/ but had no test-file move to make, since this test does not exist on upstream/master yet - it was added later on this branch. This is that missing test-file move, done to match the source move exactly: mirrored path, plus the CMakeLists.txt and GOTestExe.cpp registration updates. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together with the preceding include-fix commit, they complete PR 1 as it applies to this branch. Build clean in build/current (Debug, GO_BUILD_TESTING=ON); ./bin/GOTestExe passes GOTestSoundOnePoleFilter, GOTestSoundShelfFilterProcessor and GOTestSoundEnclosureShelfMapper. The GOTestPerfSoundBufferMutable/ GOTestPerfSoundBufferPlanarMutable failures are pre-existing, unrelated Debug perf-baseline misses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) wrote the sound/ directory breakdown from upstream/master, which has neither directory - both exist only on this branch (GOSoundShelfFilterProcessor, GOSoundEnclosureShelfMapper). Filling in the two entries the cherry-picked text couldn't know about, and sharpening the placement rule to name them directly instead of the vaguer "model-aware layer above processing/" wording that stood in for them. Squash into the PR GrandOrgue#2635 cherry-pick commit once this branch is rebased past GrandOrgue#2635's merge, together with the two preceding commits - the three together are PR 1 as it applies to this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

oleg68 · 2026-10-01T13:58:30Z

@oleg68 You need to rebase

@rousseldenis Done

oleg68 · 2026-10-02T13:26:57Z

@rousseldenis Could you approve this PR as soon as possible. It is jost simple: only moving files and changing of include directories. There are no code changes at all.

PR GrandOrgue#2635 (GrandOrgue#2635) moved GOSoundResample/GOSoundOnePoleFilter into sound/dsp-kernels/, but was branched from upstream/master, which lacks sound/effects/ and sound/mappers/ entirely - so it could not update the two consumers that exist only on this branch: GOSoundShelfFilterProcessor.h and GOTestSoundEnclosureShelfMapper.cpp. This is the remainder of that same include-path fix, scoped to what this branch actually has. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together they are exactly PR 1 as it applies here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

PR GrandOrgue#2635 (GrandOrgue#2635) moved the test's target class into sound/dsp-kernels/ but had no test-file move to make, since this test does not exist on upstream/master yet - it was added later on this branch. This is that missing test-file move, done to match the source move exactly: mirrored path, plus the CMakeLists.txt and GOTestExe.cpp registration updates. Squash into the PR GrandOrgue#2635 cherry-pick commit ("Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/") once this branch is rebased past GrandOrgue#2635's merge - together with the preceding include-fix commit, they complete PR 1 as it applies to this branch. Build clean in build/current (Debug, GO_BUILD_TESTING=ON); ./bin/GOTestExe passes GOTestSoundOnePoleFilter, GOTestSoundShelfFilterProcessor and GOTestSoundEnclosureShelfMapper. The GOTestPerfSoundBufferMutable/ GOTestPerfSoundBufferPlanarMutable failures are pre-existing, unrelated Debug perf-baseline misses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

oleg68 changed the title ~~Move GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/~~ Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/ Sep 23, 2026

oleg68 force-pushed the refactor/sound-dsp-kernels branch 2 times, most recently from da46dae to 02a34b0 Compare September 23, 2026 17:41

oleg68 requested review from larspalo and rousseldenis September 24, 2026 06:23

oleg68 force-pushed the refactor/sound-dsp-kernels branch from 02a34b0 to 7f4dd52 Compare October 1, 2026 13:57

rousseldenis approved these changes Oct 5, 2026

View reviewed changes

oleg68 merged commit a7be5de into GrandOrgue:master Oct 5, 2026
16 checks passed

oleg68 deleted the refactor/sound-dsp-kernels branch October 5, 2026 16:01

This was referenced Oct 7, 2026

Moved GOTestSoundOnePoleFilter into src/tests/testing/sound/dsp-kernels/ #2650

Open

Moved GOTestSoundOnePoleFilter into src/tests/testing/sound/dsp-kernels/ oleg68/GrandOrgue-official#17

Closed

Navigation Menu

Repository navigation

Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/ - #2635

Moved GOSoundResample and GOSoundOnePoleFilter into sound/dsp-kernels/#2635
oleg68 merged 1 commit into
GrandOrgue:masterfrom
oleg68:refactor/sound-dsp-kernels

oleg68 commented Sep 22, 2026

Uh oh!

codecov-commenter commented Sep 22, 2026

Uh oh!

oleg68 commented Sep 28, 2026

Uh oh!

rousseldenis commented Oct 1, 2026

Uh oh!

oleg68 commented Oct 1, 2026 •

edited

Loading

Uh oh!

oleg68 commented Oct 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

oleg68 commented Sep 22, 2026

Summary

Test plan

Uh oh!

codecov-commenter commented Sep 22, 2026

Codecov Report

Uh oh!

oleg68 commented Sep 28, 2026

Uh oh!

rousseldenis commented Oct 1, 2026

Uh oh!

oleg68 commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleg68 commented Oct 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oleg68 commented Oct 1, 2026 •

edited

Loading