chore(i18n): Update placeholders for better clarity#648
Conversation
Reported at Transifex
H2CK
left a comment
H2CK
left a comment
There was a problem hiding this comment.
Please have a look at the comments added to the changes.
| <NcTextField v-model="editClient.allowedScopes" | ||
| :label="t('oidc', 'Allowed Scopes')" | ||
| :placeholder="t('oidc', 'openid profile roles')" | ||
| :placeholder="t('oidc', 'OpenID profile roles')" |
There was a problem hiding this comment.
From my understanding the placeholder should be some kind of example what to enter into the input field. Since the scopes are standardized it shall be openid (in lowercase). From my point of view the translation for this string should be removed at all to eliminate any confusion during translation, since the scope name could not be translated.
| <NcTextField v-model="customClaimModal.scope" | ||
| :label="t('oidc', 'Scope')" | ||
| :placeholder="t('oidc', 'profile')" | ||
| :placeholder="t('oidc', 'Profile')" |
There was a problem hiding this comment.
As in line 171 here the placeholder contains an example for a defined scope (e.g., profile). The standardized scopes like profile can not be translated. Therefor the translation for this string should be removed.
| :label="t('oidc', 'Name')" | ||
| :disabled="customClaimModal.isEdit" | ||
| :placeholder="t('oidc', 'is_admin')" | ||
| :placeholder="t('oidc', 'Is administrator?')" |
There was a problem hiding this comment.
The placeholder is an example how the custom claim could look like (here: is_admin). Whitespaces and question marks are not allowed as valid chars in the claim name according to the standard. Therefore the proposed change will no longer show a valid input into the field.
If this placeholder causes trouble during translations, then maybe the translation for this placeholder should be removed.
After reading your comments I fully support to remove translations of given strings. I do not know the necessary code changes to do that. Translators appreciate it. |
|
Necessary changes will be made outside of this PR. |
2 participants
Reported at Transifex