Skip to content

chore(i18n): Update placeholders for better clarity #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rakekniven wants to merge 1 commit into from
Closed

chore(i18n): Update placeholders for better clarity #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
style="max-width: 100%; width: 740px;">
<NcTextField v-model="editClient.allowedScopes"
:label="t('oidc', 'Allowed Scopes')"
:placeholder="t('oidc', 'openid profile roles')"
:placeholder="t('oidc', 'OpenID profile roles')"
Copy link
Copy Markdown
Owner

@H2CK H2CK May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding the placeholder should be some kind of example what to enter into the input field. Since the scopes are standardized it shall be openid (in lowercase). From my point of view the translation for this string should be removed at all to eliminate any confusion during translation, since the scope name could not be translated.

:helper-text="t('oidc', 'Define the allowed scopes for the client separated by a whitespace, e.g. openid profile roles. Do not enter any value to allow all scopes.')" />
<NcTextField id="emailRegex"
v-model="editClient.emailRegex"
Expand Down Expand Up @@ -476,11 +476,11 @@
<NcTextField v-model="customClaimModal.name"
:label="t('oidc', 'Name')"
:disabled="customClaimModal.isEdit"
:placeholder="t('oidc', 'is_admin')"
:placeholder="t('oidc', 'Is administrator?')"
Copy link
Copy Markdown
Owner

@H2CK H2CK May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder is an example how the custom claim could look like (here: is_admin). Whitespaces and question marks are not allowed as valid chars in the claim name according to the standard. Therefore the proposed change will no longer show a valid input into the field.
If this placeholder causes trouble during translations, then maybe the translation for this placeholder should be removed.

:helper-text="t('oidc', 'Define the name of the custom claim.')" />
<NcTextField v-model="customClaimModal.scope"
:label="t('oidc', 'Scope')"
:placeholder="t('oidc', 'profile')"
:placeholder="t('oidc', 'Profile')"
Copy link
Copy Markdown
Owner

@H2CK H2CK May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in line 171 here the placeholder contains an example for a defined scope (e.g., profile). The standardized scopes like profile can not be translated. Therefor the translation for this string should be removed.

:helper-text="t('oidc', 'The custom claim will be provided when the defined scope is requested.')" />
<NcSelect v-bind="customClaimModal.function.props"
v-model="customClaimModal.function.props.value"
Expand Down
Loading