kits: the tab a launch opens is the tab the app lands in - #241
Merged
Merged
Conversation
window.open with noopener returns null, so the tab opened on the click stayed blank and the app went to a second tab the popup blocker could refuse. The kit app is this origin's own page, so the tab keeps its handle and is navigated once the launch returns. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
richard-epsilla
approved these changes
Sep 22, 2026
richard-epsilla
left a comment
richard-epsilla
left a comment
Collaborator
There was a problem hiding this comment.
Same fix as the hosted console; checks green.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.openwithnoopenerreturns null, so the tab opened on the click stayed blank forever and the app went to a second tab the popup blocker was entitled to refuse. The kit app is this origin's own page, so the tab keeps its handle and is navigated once the launch returns.Seen on the hosted service while verifying the kits end to end; same code here.
Patch release: v0.23.5.
🤖 Generated with Claude Code