Skip to content

kits: the tab a launch opens is the tab the app lands in #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richard-epsilla merged 2 commits into from
Sep 22, 2026
+4 −2
Merged

kits: the tab a launch opens is the tab the app lands in #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc610e0
kits: the tab a launch opens is the tab the app lands in
richard-epsilla Sep 22, 2026
cfe4922
ci: run the checks on #241
richard-epsilla Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ui/src/app/(app)/kits/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,17 @@ export default function KitsPage() {
}, []);

/** A kit app runs outside this Next app, so it gets its own tab. */
/** The kit app is this origin's own page, so the tab keeps its handle: `noopener` makes
* window.open return null, which is what left the tab launch opened blank forever. */
function openApp(route: string) {
window.open(route, '_blank', 'noopener,noreferrer');
window.open(route, '_blank');
}

async function launch(kit: Kit, base?: string, model?: string, database?: DbDraft) {
// Open the tab NOW, on the click, and navigate it when the launch returns. Opening it after
// the await is a popup the browser is entitled to block, because by then it is no longer a
// user gesture.
const tab = window.open('', '_blank', 'noopener,noreferrer');
const tab = window.open('', '_blank');
setBusy(kit.id); setErr('');
try {
const r = await harnessFetch(`/api/harness/v1/kits/${kit.id}/launch`, {
Expand Down
Loading