fix(bot): prevent bot freeze by resetting failed init promise#85
Open
Dhereal1 wants to merge 2 commits intoHyperlinksSpace:mainfrom
Open
fix(bot): prevent bot freeze by resetting failed init promise#85Dhereal1 wants to merge 2 commits intoHyperlinksSpace:mainfrom
Dhereal1 wants to merge 2 commits intoHyperlinksSpace:mainfrom
Conversation
staindart
requested changes
Apr 4, 2026
Member
staindart
left a comment
There was a problem hiding this comment.
In your webhook.ts change, you have both a .catch() and a try/catch block. Since bot.init() returns a Promise, the try/catch is actually redundant because async errors are captured by the .catch() or the returned rejected promise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If bot.init() failed once (e.g. transient network or config issue), the rejected promise was cached and reused. This caused the bot to stop processing all future updates on that instance.
Fix
Result
Testing