Repository navigation
refactor: give the charts their own barrel, with charts-react's names - #991
Merged
Merged
Conversation
Contributor
📖 Docs Preview
|
patricklx
previously approved these changes
Oct 12, 2026
aklkv
force-pushed
the
refactor/charts-barrel
branch
from
October 13, 2026 20:47
59cab77 to
38626c4
Compare
patricklx
previously approved these changes
Oct 13, 2026
Base automatically changed from
refactor/drop-component-app-reexports
to
main
October 13, 2026 21:10
aklkv
dismissed
patricklx’s stale review
October 13, 2026 21:10
The merge-base changed after approval.
aklkv
force-pushed
the
refactor/charts-barrel
branch
from
October 13, 2026 21:10
38626c4 to
f5dba68
Compare
patricklx
approved these changes
Oct 14, 2026
Carbon React ships its charts as a separate package, @carbon/charts-react, so the charts get their own barrel too: `carbon-components-ember/charts`, written by create-files.mjs from components/charts/ next to the `components` and `ai-chat` barrels. BarChart wraps @carbon/charts' SimpleBarChart, which is what charts-react calls it, so it becomes SimpleBarChart (charts/simple-bar-chart.gts, docs page Charts/SimpleBarChart). LineChart and PieChart already match. The manifest preset knows the new barrel, so the docs agents read import the charts from it. The README, AGENTS.md and the agent skill list it. Breaking: import the charts from `carbon-components-ember/charts`, and BarChart as SimpleBarChart. Signed-off-by: Alexey Kulakov <uni_que@me.com>
aklkv
force-pushed
the
refactor/charts-barrel
branch
from
October 14, 2026 06:49
f5dba68 to
ed9ee45
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #990 (on #988, #987 and #986): merge those first, then retarget this to
main.Carbon React ships its charts as a separate package,
@carbon/charts-react. So the charts get their own barrel too, like AI Chat in #988:carbon-components-ember/charts.Changes
create-files.mjswrites a third barrel,src/charts.ts, fromcomponents/charts/, so thecomponentsbarrel no longer has the charts.BarChartwraps@carbon/charts'SimpleBarChart, which is what charts-react calls it, so it becomesSimpleBarChart(charts/simple-bar-chart.gts, docs page Charts/SimpleBarChart).LineChartandPieChartalready match.carbon-components-ember/charts(44 components fromai-chat, 3 fromcharts, 112 fromcomponents). The skill's React guide maps@carbon/charts-reactimports to it.Breaking
carbon-components-ember/charts.BarChartis nowSimpleBarChart.Verified