Repository navigation
Conversation
…m generate` create-files.mjs did two unrelated jobs. icons.mjs now writes the icon components from @carbon/icons and their module declarations; barrels.mjs writes the four barrels (components, ai-chat, charts and icons). The scripts that write source files share a `generate` prefix, apart from `build`, which writes dist/: - `generate` runs `generate:icons`, then `generate:barrels` (was `create-autogenerated-files`) - `generate:skill-references` (was `create-skill-references`; the script is now scripts/skill-references.mjs) CI, prepack, AGENTS.md, CONTRIBUTING.md and the parity agent's prompt use the new names. The icon barrel now goes through the same writeBarrel as the others, in place of its own copy of the naming code, and gains the duplicate-name check. All the generated files are byte-for-byte the same as before. barrels.mjs fails, rather than writing an empty icon barrel, if it runs before icons.mjs. Signed-off-by: Alexey Kulakov <uni_que@me.com>
aklkv
force-pushed
the
chore/split-create-files
branch
from
October 11, 2026 22:32
4ef2c0e to
9245b8e
Compare
aklkv
changed the title
pnpm generate
aklkv
added this pull request to stack #989
October 11, 2026 22:37
patricklx
approved these changes
Oct 12, 2026
patricklx
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #991 (on #990, #988, #987 and #986): merge those first, then retarget this to
main.create-files.mjsdid two unrelated jobs, so it's split in two:scripts/icons.mjswrites an Ember component for each@carbon/iconsicon intosrc/components/icons/, and their module declarations intounpublished-development-types/carbon-icons.d.ts.scripts/barrels.mjswrites the four barrels:src/components.ts,src/ai-chat.ts,src/charts.tsandsrc/icons.ts.The scripts that write source files now share a
generateprefix, apart frombuild, which writesdist/:create-autogenerated-filesgenerate(runsgenerate:icons, thengenerate:barrels)create-skill-references(scripts/create-skill-references.mjs)generate:skill-references(scripts/skill-references.mjs)CI, prepack, AGENTS.md, CONTRIBUTING.md and the parity agent's prompt use the new names.
The icon barrel now goes through the same
writeBarrelas the others, in place of its own copy of the naming code, and gains the duplicate-name check.barrels.mjsfails, rather than writing an empty icon barrel, if it runs beforeicons.mjs.Verified
Running the old and new scripts gives byte-for-byte the same output: the four barrels, the type declarations and all 2,760 icon files.