fix: add YAML frontmatter to business-docs-sync skill#13
Open
xiaolai wants to merge 1 commit into
Open
Conversation
The skill file had no frontmatter at all — both required name and description fields were missing. Without frontmatter the Skill tool cannot discover or invoke it. Co-Authored-By: Claude Code <noreply@anthropic.com>
4 tasks
There was a problem hiding this comment.
Code Review
This pull request adds metadata frontmatter to the business-docs-sync skill documentation, defining its name and purpose. A review comment suggests updating the description to include specific workflow step designations and trigger keywords to maintain consistency with other skills in the Evaluate-Loop.
| @@ -1,3 +1,8 @@ | |||
| --- | |||
| name: business-docs-sync | |||
| description: Use when completing a track that changes pricing, AI models, product features, or asset pipelines — syncs business context documents across all tiers. | |||
There was a problem hiding this comment.
To maintain consistency with other skills in the Evaluate-Loop (such as loop-executor and loop-execution-evaluator), the description should include the step designation and explicit trigger keywords. This ensures the Skill tool and agents can accurately identify and invoke the skill based on the defined workflow.
Suggested change
| description: Use when completing a track that changes pricing, AI models, product features, or asset pipelines — syncs business context documents across all tiers. | |
| description: "Evaluate-Loop Step 5.5: BUSINESS DOC SYNC. Use when completing a track that changes pricing, AI models, product features, or asset pipelines — syncs business context documents across all tiers. Triggered by: track completion, evaluation complete, or '/conductor sync-docs'." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
skills/business-docs-sync/SKILL.mdhas no YAML frontmatter — the file opens directly with# Business Document Sync Strategy; both requirednameanddescriptionfields are absent, making the skill invisible to the Skill tool and preventing it from being discovered or invoked.Evidence:
head -1 skills/business-docs-sync/SKILL.md→# Business Document Sync Strategy(no preceding---block); the Skill tool requiresnamein frontmatter for registration.Fix: Added minimal YAML frontmatter with
name: business-docs-syncand adescriptionmatching the skill's stated trigger conditions.