Skip to content

Fix Windows Electron archive extraction - #309

Merged
IgorWarzocha merged 1 commit into
devfrom
fix/windows-electron-extraction
Aug 19, 2026
Merged

Fix Windows Electron archive extraction#309
IgorWarzocha merged 1 commit into
devfrom
fix/windows-electron-extraction

Conversation

@IgorWarzocha

@IgorWarzocha IgorWarzocha commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes both Windows release jobs failing during Electron installation.
  • Passes the archive and destination paths through child-process environment variables instead of appending them after PowerShell's -Command, where $args was empty.
  • Makes PowerShell archive errors terminating so extraction failures remain visible.

Validation

  • bun run ai:check
  • 45 test files / 111 tests passed
  • React Doctor: 100/100
  • Manual release dispatch 32294794463: Windows x64 and Windows ARM64 builds passed.

The changelog is unchanged because this repairs pre-release CI rather than shipped product behaviour.

@IgorWarzocha

Copy link
Copy Markdown
Owner Author

@codex please review this PR and give me 10-20 issues if any. Categorize findings as required, recommended, or optional.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: a01de4ad0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@IgorWarzocha
IgorWarzocha merged commit 1764e50 into dev Aug 19, 2026
15 of 19 checks passed
@IgorWarzocha
IgorWarzocha deleted the fix/windows-electron-extraction branch August 19, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant