Skip to content

Fix Windows Electron archive extraction #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IgorWarzocha merged 1 commit into from
Aug 19, 2026
+11 −4
Merged

Fix Windows Electron archive extraction #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions scripts/install-electron.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,24 @@ async function extractZip(zipPath, distPath) {
// the first entry under Node 26. The Electron archives are ordinary zip files,
// so use OS-provided archive tools and verify the executable afterward.
if (process.platform === 'win32') {
const archivePathEnv = 'HOWCODE_ELECTRON_ARCHIVE_PATH'
const destinationPathEnv = 'HOWCODE_ELECTRON_DESTINATION_PATH'
childProcess.execFileSync(
'powershell.exe',
[
'-NoProfile',
'-NonInteractive',
'-Command',
'Expand-Archive -LiteralPath $args[0] -DestinationPath $args[1] -Force',
zipPath,
distPath,
`$ErrorActionPreference = 'Stop'; Expand-Archive -LiteralPath $env:${archivePathEnv} -DestinationPath $env:${destinationPathEnv} -Force`,
],
{ stdio: 'inherit' },
{
stdio: 'inherit',
env: {
...process.env,
[archivePathEnv]: zipPath,
[destinationPathEnv]: distPath,
},
},
)
return
}
Expand Down