Repository navigation
feat(profiles): scope reader preferences - #17
Merged
Merged
Conversation
ReaderProfile.init(from:) validated the decoded name with validatedNickname, which throws for names that were valid under the old sanitizer (spaces, digits). Combined with try? decode([ReaderProfile].self), one such legacy name wiped the entire profiles array on upgrade. Decode now sanitizes the name to a valid form (or defaultName); validation still throws at the create/update boundary.
# Conflicts: # Piperly/Services/BookStore.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BookStoreinstead of global app storage.Why
Families can share one Piperly library while each reader keeps their own reading and voice preferences. Validation also belongs at the model boundary so invalid profile data cannot bypass the form.
Impact
Switching profiles now switches the reader's full preference set. Existing encoded profiles receive safe defaults for the new fields. Because there are no shipped users, this does not migrate values from the removed global preference keys.
Validation
Stack
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.