Repository navigation
feat(library): add stable book identity - #18
Merged
Merged
Conversation
Book.contentIdentity was a required non-optional field with synthesized Codable, so any book persisted before this PR failed to decode and, via try? decode([Book].self), wiped the entire library on upgrade. Decode now defaults a missing contentIdentity to "" so the record survives; legacy files still resolve through their original fileName. Adds backfillContentIdentities() (mirrors backfillCovers) to hash each legacy file, adopt the real identity, and migrate it to the deterministic <hash>.epub name, dropping duplicates that already exist under that name.
# Conflicts: # Piperly/Services/BookStore.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bookrecord nameWhy
Local UUIDs are useful for on-device relationships, but they are not stable across devices. Hashing the EPUB bytes gives the same book a stable identity everywhere and establishes the foundation the private sync engine needs.
Impact
Import safeguards
Tests
Stack
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.