Put the changelog back in the release notes - #25
Merged
Conversation
PowerShell captures multi-line command output as an Object[]. The publish step took the changelog straight from release_notes.py and dropped it into the $notes array as a single element, so it stringified to "System.Object[]" -- which is exactly what shipped in place of the changelog on v0.4.0-rc.2 and v0.4.0-rc.3. Only a one-line entry survived, and real entries never are. Verified in pwsh 7: with an Object[] the current form yields "System.Object[]" and the joined form yields the text; with a plain string both are identical, so single-line entries are unaffected. The gate pins the joined form, since the failure is silent -- the release publishes, the notes are simply wrong, and nothing reads them until someone opens the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.4.0-rc.2andv0.4.0-rc.3both publishedSystem.Object[]where their changelog should be.PowerShell captures multi-line command output as an
Object[]. The publish step dropped that straight into the$notesarray as one element, so it stringified instead of expanding. Only a single-line changelog entry would have survived, and real entries never are — which is why this was invisible until now.Verified against pwsh 7: with an
Object[]the current form yieldsSystem.Object[]and the joined form yields the text; with a plain string the two are identical, so nothing changes for a one-line entry.The gate pins the joined form. This failure is silent — the release publishes fine and the notes are simply wrong.
🤖 Generated with Claude Code