Skip to content

Put the changelog back in the release notes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDS300 merged 1 commit into from
Aug 16, 2026
Merged

Put the changelog back in the release notes #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build-loremaster.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,11 @@ jobs:
} else {
"Loremaster-$version-x86_64.AppImage"
}
$changelog = python tools/release_notes.py --version $tag
# -join, because PowerShell captures multi-line command output as an
# Object[]. Embedded as one element of the $notes array it stringified
# to "System.Object[]", which is what shipped in place of the changelog
# on every release whose entry spans more than one line.
$changelog = (python tools/release_notes.py --version $tag) -join "`n"
if ($LASTEXITCODE -ne 0) { throw "no changelog entry for $tag" }
$notes = @()
if ($prerelease) {
Expand Down
2 changes: 2 additions & 0 deletions tools/release_quality_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,8 @@ def check_loremaster_release_pipeline() -> None:
"actions/download-artifact@v6",
"electron-builder --win portable --x64 --publish never",
"-c.extraMetadata.version=$version",
# The changelog reaches the notes as text, not as "System.Object[]".
'$changelog = (python tools/release_notes.py --version $tag) -join "`n"',
)
missing = [value for value in required if value not in workflow]
if missing:
Expand Down